Skip to content

feat(runtime-host): manage peer meshes from Desktop - #4092

Open
M4n5ter wants to merge 6 commits into
mainfrom
feat/desktop-peer-mesh-management
Open

feat(runtime-host): manage peer meshes from Desktop#4092
M4n5ter wants to merge 6 commits into
mainfrom
feat/desktop-peer-mesh-management

Conversation

@M4n5ter

@M4n5ter M4n5ter commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
English

Summary

Complete the operator and Desktop management slice for experimental Runtime Host Peer Meshes:

  • add owner-only Runtime Host operations for querying, creating, inviting, joining, removing, leaving, closing, and reconciling a Mesh
  • keep durable Mesh state scoped to the native peer identity and keep one-time invitations out of process arguments
  • expose the same closed management vocabulary through the CLI, local Desktop, and SSH-managed Hosts
  • add a compact Desktop surface for identity, roster revision, route state, invitations, and membership changes

Remote principals do not receive these operations. Manual direct-peer listeners remain direct-only; managed peer services opt into resident Mesh state explicitly.

Refs #3842

Verification

  • npm run build
  • npm run typecheck
  • npm run lint
  • npm run format:check
  • npm run astryx:surface-inventory
  • npm run check:asf-headers
  • npx knip --workspace apps/desktop
  • npx knip --workspace packages/ui
  • 55 focused Runtime Host, CLI, and Desktop tests
  • visible Electron walkthrough of create and invite flows
  • real macOS Desktop ↔ Linux Host join, route reconciliation, member removal, persistence across restart, and clean shutdown

Screenshots

Two-member cross-machine Mesh after reconciliation:

The same Desktop Mesh persisted after restart:

简体中文

概要

完成实验性 Runtime Host Peer Mesh 的 operator 与 Desktop 管理闭环：

  • 新增仅 Owner 可用的 Mesh 查询、创建、邀请、加入、移除、退出、关闭和同步操作
  • 按 native peer identity 隔离持久 Mesh 状态，一次性邀请不会进入进程参数
  • CLI、本机 Desktop 与 SSH 管理的 Host 共用同一组封闭的管理操作
  • Desktop 以紧凑界面展示身份、roster revision、路径状态、邀请和成员变更

Remote principal 不会获得这些操作。手动 direct-peer listener 仍保持 direct-only；只有 managed peer service 会显式启用 resident Mesh state。

关联 #3842

验证

  • npm run build
  • npm run typecheck
  • npm run lint
  • npm run format:check
  • npm run astryx:surface-inventory
  • npm run check:asf-headers
  • npx knip --workspace apps/desktop
  • npx knip --workspace packages/ui
  • 55 个聚焦 Runtime Host、CLI 与 Desktop 的测试
  • 在可见 Electron 窗口中验证创建和邀请流程
  • 真实验证 macOS Desktop ↔ Linux Host 加入、路径同步、成员移除、重启持久化和干净退出

截图

英文部分中的截图分别展示了真实跨机器的双成员 Mesh，以及 Desktop 重启后的 Mesh 持久化结果。

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex assisted with implementation, tests, cross-machine verification, and pull request preparation under the contributor's direction. Human review and merge approval remain pending.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@M4n5ter
M4n5ter marked this pull request as ready for review August 28, 2026 13:49
@M4n5ter
M4n5ter marked this pull request as draft August 28, 2026 13:49
@M4n5ter M4n5ter mentioned this pull request Aug 28, 2026
Open
@M4n5ter
M4n5ter marked this pull request as ready for review August 28, 2026 13:50
@github-actions github-actions Bot added the effort/XL Over 1000 readable lines label Aug 28, 2026
jackwener
jackwener approved these changes Aug 28, 2026
View reviewed changes

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed exact head c1615f761e613c50843fca43bac3b91bc4bf5b1a and found no blocking issue.

The new management surface preserves the important authority boundaries: Peer Mesh operations are absent from the closed remote-owner grant list, managed SSH connects through the Host's local-owner channel, and one-time invitation material is sent over stdin rather than process arguments. Persistent state is namespaced by the native peer identity, the protocol change advances the compatibility epoch to 61, inputs and projections are bounded, and the current-main synthetic merge is clean.

One non-blocking follow-up: peer.mesh.reconcile currently maps every thrown error to “could not reach any current route.” Reconciliation can also persist route or roster updates, so PeerMeshPersistenceError and PeerMeshPostCommitError should retain the same persistence_failed / commit_outcome_unknown classification used by the other Mesh mutations. The operation is fail-closed and reconciliation is idempotent, so I do not consider this an approval blocker, but the current message can misdiagnose a storage failure as network unavailability.

The exact-head hosted workflows were still running when I submitted this review.

Posted by an automated review agent operated by @WAWQAQ. This is not an
independent human review and does not satisfy the committer review required by
CONTRIBUTING.md. A human is accountable for this comment — please push back if
anything here is wrong.

简体中文

本条评论由 @WAWQAQ 运行的自动化审查程序发出。它不构成 CONTRIBUTING.md
所要求的独立人类审查，也不能替代人类审查。有人类对本条评论负责，如有错误请直接指出。

M4n5ter added 2 commits August 28, 2026 22:16
@M4n5ter
feat(runtime-host): manage peer meshes from Desktop
4502680 
Add owner-only Mesh management operations and expose them through the CLI and Desktop local or SSH-managed endpoints. Preserve Mesh state by peer identity and keep invitations out of command arguments.

Generated-by: OpenAI Codex
@M4n5ter
fix(runtime-host): harden peer mesh management boundaries
3823f48 
Validate the managed target before requesting a one-time invitation.

Commit Mesh creation atomically, preserve durable failure outcomes, and connect resident owner failure to Host shutdown. Keep optional Desktop Mesh state from blocking Direct peer startup and use one wire invitation contract.

Generated-by: OpenAI Codex
@M4n5ter
M4n5ter force-pushed the feat/desktop-peer-mesh-management branch from 9bc882a to 3823f48 Compare August 28, 2026 14:17
M4n5ter added 4 commits August 28, 2026 23:01
@M4n5ter
fix(runtime-host): close peer mesh management gaps
dba8097 
Return authoritative post-operation snapshots, keep invitation I/O line-safe, and bound reconciliation work. Propagate terminal Mesh persistence failures while preserving Direct peer fallback where Mesh is optional.

Generated-by: OpenAI Codex
@M4n5ter
refactor(desktop): focus peer mesh management flows
4f0249b 
Separate overview, join, and invitation tasks so the primary action stays visible without scrolling. Keep dialog actions in a fixed footer and simplify mesh/member presentation for compact windows.\n\nGenerated-by: OpenAI Codex
@M4n5ter
fix(runtime-host): preserve peer mesh identity and convergence
b8adcdd 
Reject Direct peer identity rotation while active Mesh state exists, use learned authority routes for leave, and reconcile each membership through bounded authority-or-gossip attempts. Remove duplicate projection identity and the unused operator capability contract.\n\nGenerated-by: OpenAI Codex
@M4n5ter
fix(runtime-host): finish peer mesh management
f498202 
Preserve legacy state and authoritative convergence across owner upgrades. Simplify invitation expiry and restructure Desktop management flows so join and invitation actions remain visible at compact window sizes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwener jackwener jackwener approved these changes

Assignees

No one assigned

Labels

effort/XL Over 1000 readable lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@M4n5ter @jackwener